Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Cleanup runConfigId / input merging #179

Merged
merged 1 commit into from
Dec 1, 2024
Merged

chore: Cleanup runConfigId / input merging #179

merged 1 commit into from
Dec 1, 2024

Conversation

johnjcsmith
Copy link
Contributor

Cleanup createRun handling of Run Configurations.

  • Deprecate run.config object and replace with
  • run.configId
  • run.input

run.input will be merged with initialPrompt regardless of whether or not a config is being used.

@johnjcsmith johnjcsmith force-pushed the chore/cleanup-config-input branch from a842f54 to d641799 Compare December 1, 2024 05:46
@johnjcsmith johnjcsmith force-pushed the chore/cleanup-config-input branch from d641799 to 18e4abb Compare December 1, 2024 05:53
@johnjcsmith johnjcsmith merged commit 05fbcfa into main Dec 1, 2024
23 checks passed
@johnjcsmith johnjcsmith deleted the chore/cleanup-config-input branch December 1, 2024 06:08
johnjcsmith added a commit that referenced this pull request Dec 1, 2024
@johnjcsmith
Revert "chore: Cleanup runConfigId / input merging (#179)"
123bfed 
This reverts commit 05fbcfa.
@johnjcsmith johnjcsmith mentioned this pull request Dec 1, 2024
Merged
johnjcsmith added a commit that referenced this pull request Dec 1, 2024
@johnjcsmith
Revert "chore: Cleanup runConfigId / input merging (#179)" (#181)
873dcd9 
This reverts commit 05fbcfa.
johnjcsmith added a commit that referenced this pull request Dec 1, 2024
@johnjcsmith
Revert "Revert "chore: Cleanup runConfigId / input merging (#179)" (#181
598b94b 
)"

This reverts commit 873dcd9.
johnjcsmith added a commit that referenced this pull request Dec 2, 2024
@johnjcsmith
chore: Re-apply options changes (#182)
ce6cc6d 
* Revert "Revert "chore: Cleanup runConfigId / input merging (#179)" (#181)"

This reverts commit 873dcd9.

* feat: Correct  input handling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@johnjcsmith